FIX: Suppress errors when translating #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
reviewed
May 15, 2025
Comment on lines
+23
to
+24
| rescue FinalDestination::SSRFDetector::LookupFailedError | ||
| # do nothing, there are too many sporadic lookup failures |
Contributor
There was a problem hiding this comment.
Do we want to consider queuing the job again instead with some delay? I'm curious what happens if we do nothing here.
Contributor
Author
There was a problem hiding this comment.
We shouldn't need to. This job itself is not critical as the backfill scheduled job will cover any failures. The backfill does most recent posts first.
Contributor
There was a problem hiding this comment.
Thank you for the clarification!
tgxworld
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two errors here being handled
translatemethod on purpose, but rather at the usages.